Simplify Jest configuration #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI seems to be failing. |
|
Yes, the CI failures are caused by the test typings being a bit off, which also happens to me locally. It is fixed in #154 and the CI should pass when that one is merged and I rebase this. |
surilindur
force-pushed
the
chore/simplify-jest-config
branch
from
eed5334 to
01174b5
Compare
surilindur
force-pushed
the
chore/simplify-jest-config
branch
from
01174b5 to
f4d9bca
Compare
|
This is now ready for review! I forgot I had this open, as well. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change to collect the Jest configs into a single file as in the main Comunica repo, and to convert it into TypeScript for easier typing support, and to set it apart from all the transpiler-generated code. The addition of
ts-nodeis to support the TS format of the config.Any feedback is welcome. 🙂